Update API and support for draft 20 #6
Conversation
wip - add id2 mdoc request support id2 WIP fix mdl path matching oid4vp id2 WIP OID4VP ID2 use ssh for isomdl dep clean up update isomdl version
…o feat/oidc4vp-ID2
- rename crate - make http client to be configurable - refactor traits and request builder - add client metadata resolution
cobward
requested review from
rschulman,
theosirian,
sbihel,
Juliano1612,
justAnIdentity and
todd-spruceid
There was a problem hiding this comment.
Looks great and should be ready for people to start implementing.
I have a few questions though:
- This doesn't yet support OID4VP Error Responses. Do we feel comfortable putting that on the sprucekit implementers? I think it's better if that lives here
- Same for the RequestVerifier trait implementation for client_id_schemes. I think we should have a default trait implementation here, not in the sprucekit wallet.
- It doesn't look like we're fully ready for PresentationExchange 2.0, with SubmissionRequirementPicks being ignored in the PresentationDefinition parsing.
Should I open issues for these on this repo?
|
Maybe we should also provide some support structs for creating JARMs |
.cargo/config.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [net] | |||
| git-fetch-with-cli = true | |||
There was a problem hiding this comment.
I don't think this is required now that all dependencies are public (or not git at all)
src/core/util/mod.rs
Outdated
| /// | ||
| /// A trait is used here so to facilitate native HTTP/TLS when compiled for mobile applications. | ||
| #[async_trait] | ||
| pub trait HttpClient { |
There was a problem hiding this comment.
I think it would be good to rename this AsyncHttpClient to avoid any confusion
src/wallet.rs
Outdated
|
|
||
| #[async_trait] | ||
| pub trait Wallet: RequestVerifier + Sync { | ||
| type HttpClient: HttpClient + Send + Sync; |
There was a problem hiding this comment.
All these Send + Sync will be a problem if we want to update vp_interop
There was a problem hiding this comment.
Discussed, we will leave it for now and address this later if needed.
Good point, will add an issue for this.
I disagree with this. There's so much custom stuff that goes into handling the client_id_schemes. We do have some "generic" support for
Yep, I'm adding a issue to generally improve our Presentation Exchange support. We need to have some support for parsing and handling the request, either here or in SpruceKit Mobile.
I will add an issue for this too - but we also need to consider that we might need to use native crypto in order to meet requirements for FIPS 140-X cryptography. |
No description provided.