feat/improve-presentation-exchange-support-in-oid4vp-rs #9
Conversation
add implementation methods for Presentation Definition. WIP: Need to continue work for Presentation Submission and the rest of the structs used in the presentation exchange flow. Signed-off-by: Ryan Tate <[email protected]> Co-authored-by: Todd Showalter <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
…e for presentation exchange Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
feat/improve-presentation-exchange-support-in-oid4vp-rs
branch
from
2bd0d00 to
26dda42
Compare
Signed-off-by: Ryan Tate <[email protected]>
…erialization Signed-off-by: Ryan Tate <[email protected]>
…nto f64 Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
|
Todd helped point out that I need to add the submodules for the presentation-exchange. Will re-run tests now that I have the tests locally. |
…ormat failing test cases Signed-off-by: Ryan Tate <[email protected]>
|
d18f56d should fix the CI test failures. |
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| filter: Option<SchemaValidator>, | ||
| filter: Option<serde_json::Value>, |
There was a problem hiding this comment.
Replacing SchemaValidator to use a generic Value type and using jsonschema to perform the validation.
SchemaValidator provides helpful methods to construct a filter object and will perform some validation, but it is not as feature rich as jsonschema.
Consider removing SchemaValidator from the code, unless there is a reason to keep it.
There was a problem hiding this comment.
I would be in favour of removing it, I think we eventually need a more featureful builder than what it currently is anyway.
There was a problem hiding this comment.
I'll wire up the schema validation (using jsonschema) in #8 and remove the schema validator from this PR.
Signed-off-by: Ryan Tate <[email protected]>
add implementation methods for Presentation Definition.
WIP: Need to continue work for Presentation Submission and the rest of the structs used in the presentation exchange flow.
Many thanks to @todd-spruceid for pair programming on this.