refactor!: pydantic v2 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: spruceid#50 fixes: spruceid#54 NOTE: uses annotation trick
|
A note that python 3.8 and 3.9 not supported on macos-latest right now |
|
Sorry @sbihel @ameyarao98, CI should be fixed now |
sbihel
approved these changes
Apr 29, 2024
|
Thank you! |
This was referenced Apr 29, 2024
Closed
|
Published as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors to use pydantic v2 API and updates most of the other pins to be more recent versions (removed
dateutil)Resolves issues with
AnyURLby leveraging a trick that creates a field which uses it for validation, but retains it as a stringAdditionally refactors the ISO-8601 datetime strings using a similar trick that is compatible with v2 and is clearer and easier to use
Lastly, adds a test showing that the model is compatible for use with FastAPI as a data field item (for forms and such)
fixes: #46
fixes: #58
fixes: #50
fixes: #54
fixes: #56