Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen eth-account, eth-utils and eth-typing dependencies. #70

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

derekpierre
Copy link
Contributor

@derekpierre derekpierre commented Jul 17, 2024

Issue

I'm trying to use the latest siwe-py library which has a fix I need in a newer version (>v2.4.1) but has the following dependencies (https://github.com/spruceid/siwe-py/blob/v4.1.0/pyproject.toml):

eth-account = ">=0.11,<0.12"
eth-typing = "^4"  # peer of eth-account/web3
eth-utils = "^4"  # peer of eth-account/web3

However, I'm also using eth-ape for testing, which has the following dependencies:

"eth-account>=0.11.2,<0.12",
"eth-typing>=3.5.2,<4",
"eth-utils>=2.3.1,<3",

and therefore I now have conflicting dependencies with eth-typing and eth-utils because eth-ape wants versions <4, <3 respectively, but siwe-py wants versions 4.x.

(Issue #71 )

Resolution

Since the siwe-py library is so light, it was unclear to me the need for such a strict restriction on eth-utils and eth-typing, so I modified the pyproject.toml.

The tests for the library pass and I've tested using the update code as a github dependency and all works well, at least for the nucypher/nucypher library 😊 .

I'm hoping this can be included in a release relatively quickly.

Fixes #71 .

@derekpierre derekpierre changed the title Loosen eth-account, eth-utils and eth-typing dependencies. Loosen eth-account, eth-utils and eth-typing dependencies. Jul 17, 2024
@sbihel
Copy link
Member

sbihel commented Jul 22, 2024

This is starting to get complex and would deserve to run the tests for various versions of eth-account, but I'm going to trust that you tested with the older version for now.

@sbihel sbihel merged commit 18b77e6 into spruceid:main Jul 22, 2024
8 checks passed
@sbihel
Copy link
Member

sbihel commented Jul 22, 2024

Released as part of v4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen eth-account, eth-utils and eth-typing dependencies
2 participants