Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context files #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update context files #438

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 18, 2022 •
edited
Loading

clehner
clehner approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@clehner clehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real changes; some properties are just in a different order.
Check: diff <(git show HEAD:contexts/w3c-ccg-traceability-v1.jsonld | jq -S) <(git show HEAD^:contexts/w3c-ccg-traceability-v1.jsonld | jq -S)
This context file is dynamically generated upstream, so that's why we see a change like this.
If this happens a lot, we could maybe add a canonicalization step, e.g. post-process pass through jq -S - or propose that to upstream for the generator.

@github-actions github-actions bot force-pushed the fix/update-contexts branch from c5c8f7c to d100be8 Compare May 19, 2022 00:10
@clehner
Copy link
Contributor

clehner commented May 24, 2022

some properties are just in a different order.

Opened w3c-ccg/traceability-vocab#414 to attempt to address this upstream.

@github-actions github-actions bot force-pushed the fix/update-contexts branch 4 times, most recently from d57d6a1 to 67db162 Compare May 28, 2022 00:11
@github-actions github-actions bot force-pushed the fix/update-contexts branch from 67db162 to 3f9e486 Compare June 1, 2022 00:12
@clehner clehner mentioned this pull request Jun 2, 2022
Merged
clehner
clehner suggested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@clehner clehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w3c-ccg/traceability-vocab#414 was merged, so this PR (#438) now contains the property reorderings - as well as an additional change from w3c-ccg/traceability-vocab#412. #445 is opened to separate those changes. I opened #445 as a new PR rather than pushing to this one (#438)'s branch, because this one would get overwritten by the GitHub Action some time in the next 24 hours if not merged before then. #414 should replace #438 currently.

@github-actions github-actions bot force-pushed the fix/update-contexts branch from 3f9e486 to 3af5932 Compare June 8, 2022 00:12
clehner
clehner approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@clehner clehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#445 was merged, so this PR just contains normal Traceability Context changes now.

@github-actions github-actions bot force-pushed the fix/update-contexts branch 5 times, most recently from 0f4d965 to cd278c0 Compare June 18, 2022 00:10
@github-actions github-actions bot force-pushed the fix/update-contexts branch 2 times, most recently from 830883e to 22f4ef8 Compare June 23, 2022 00:10
@github-actions github-actions bot force-pushed the fix/update-contexts branch 3 times, most recently from 06b0c64 to 2e0ad2b Compare July 8, 2022 00:12
@github-actions github-actions bot force-pushed the fix/update-contexts branch 3 times, most recently from 5bc63dd to 8eebb01 Compare July 20, 2022 00:11
@github-actions github-actions bot force-pushed the fix/update-contexts branch 2 times, most recently from 94d2953 to c3385e1 Compare July 27, 2022 00:12
@github-actions github-actions bot force-pushed the fix/update-contexts branch 2 times, most recently from a490998 to 016cfab Compare August 4, 2022 00:10
@github-actions github-actions bot force-pushed the fix/update-contexts branch 7 times, most recently from 983df0e to 9415ba8 Compare April 19, 2024 00:18
@github-actions github-actions bot force-pushed the fix/update-contexts branch 7 times, most recently from 06d27dd to 653a8d4 Compare April 26, 2024 00:18
@github-actions github-actions bot force-pushed the fix/update-contexts branch 7 times, most recently from f264f73 to 817ab76 Compare May 3, 2024 00:18
@github-actions github-actions bot force-pushed the fix/update-contexts branch 6 times, most recently from 15d34f0 to 99eef84 Compare May 9, 2024 00:18
@github-actions github-actions bot force-pushed the fix/update-contexts branch from 99eef84 to 2dd37d0 Compare May 10, 2024 00:18
jceb
jceb reviewed May 17, 2024
View reviewed changes
contexts/dif-lds-ecdsa-secp256k1-recovery2020-0.0.jsonld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is HTML instead of JSON-LD

contexts/presentation-submission.jsonld
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is HTML instead of JSON-LD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jceb jceb jceb left review comments

@clehner clehner clehner approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
github_actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clehner @CLAassistant @jceb