Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename domains to domain for proof options #633

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

Ryanmtate
Copy link
Contributor

Description

Renames domains to domain in accordance with https://w3c.github.io/vc-data-integrity/#proofs domain property.

Other changes

This PR is stacked on #629 for testing with vc playground.

Tested

Testing through Sprucekit mobile-sdk-rs.

@Ryanmtate Ryanmtate force-pushed the feat/add-json-ld-types-to-vec-string branch from 3b3d21c to af0f7d0 Compare December 3, 2024 15:22
@Ryanmtate Ryanmtate force-pushed the fix/rename-di-proof-domains-to-domain branch from 35ebd2d to b3648ca Compare December 3, 2024 15:23
@Ryanmtate Ryanmtate force-pushed the feat/add-json-ld-types-to-vec-string branch 2 times, most recently from 241a884 to 030fb71 Compare December 10, 2024 03:31
@Ryanmtate Ryanmtate force-pushed the fix/rename-di-proof-domains-to-domain branch 2 times, most recently from 3440a99 to 614a1d4 Compare December 10, 2024 03:38
@Ryanmtate Ryanmtate force-pushed the feat/add-json-ld-types-to-vec-string branch from 030fb71 to 43561f0 Compare December 10, 2024 16:19
@Ryanmtate Ryanmtate force-pushed the fix/rename-di-proof-domains-to-domain branch 2 times, most recently from 7dbef05 to 3d814c2 Compare December 10, 2024 16:22
@Ryanmtate Ryanmtate force-pushed the feat/add-json-ld-types-to-vec-string branch from e1b590d to 0ff13d4 Compare December 11, 2024 18:10
@Ryanmtate Ryanmtate force-pushed the fix/rename-di-proof-domains-to-domain branch from 3d814c2 to 72f6b55 Compare December 11, 2024 18:11
Base automatically changed from feat/add-json-ld-types-to-vec-string to main December 11, 2024 18:33
@Ryanmtate Ryanmtate force-pushed the fix/rename-di-proof-domains-to-domain branch from 72f6b55 to 1e5e87f Compare December 11, 2024 18:34
Signed-off-by: Ryan Tate <[email protected]>
@Ryanmtate Ryanmtate merged commit 5211199 into main Dec 11, 2024
3 checks passed
@Ryanmtate Ryanmtate deleted the fix/rename-di-proof-domains-to-domain branch December 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants