-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename domains to domain for proof options #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanmtate
force-pushed
the
feat/add-json-ld-types-to-vec-string
branch
from
December 3, 2024 15:22
3b3d21c
to
af0f7d0
Compare
Ryanmtate
force-pushed
the
fix/rename-di-proof-domains-to-domain
branch
from
December 3, 2024 15:23
35ebd2d
to
b3648ca
Compare
timothee-haudebourg
approved these changes
Dec 6, 2024
Ryanmtate
force-pushed
the
feat/add-json-ld-types-to-vec-string
branch
2 times, most recently
from
December 10, 2024 03:31
241a884
to
030fb71
Compare
Ryanmtate
force-pushed
the
fix/rename-di-proof-domains-to-domain
branch
2 times, most recently
from
December 10, 2024 03:38
3440a99
to
614a1d4
Compare
Ryanmtate
force-pushed
the
feat/add-json-ld-types-to-vec-string
branch
from
December 10, 2024 16:19
030fb71
to
43561f0
Compare
Ryanmtate
force-pushed
the
fix/rename-di-proof-domains-to-domain
branch
2 times, most recently
from
December 10, 2024 16:22
7dbef05
to
3d814c2
Compare
Ryanmtate
force-pushed
the
feat/add-json-ld-types-to-vec-string
branch
from
December 11, 2024 18:10
e1b590d
to
0ff13d4
Compare
Ryanmtate
force-pushed
the
fix/rename-di-proof-domains-to-domain
branch
from
December 11, 2024 18:11
3d814c2
to
72f6b55
Compare
Base automatically changed from
feat/add-json-ld-types-to-vec-string
to
main
December 11, 2024 18:33
Signed-off-by: Ryan Tate <[email protected]> Co-Authored-By: Joey Silberman <[email protected]> Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]> Co-Authored-By: Joey Silberman <[email protected]> Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Co-Authored-By: Timothée Haudebourg <[email protected]> Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
fix/rename-di-proof-domains-to-domain
branch
from
December 11, 2024 18:34
72f6b55
to
1e5e87f
Compare
Signed-off-by: Ryan Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames
domains
todomain
in accordance with https://w3c.github.io/vc-data-integrity/#proofsdomain
property.Other changes
This PR is stacked on #629 for testing with vc playground.
Tested
Testing through Sprucekit
mobile-sdk-rs
.