-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve XSD dateTime and dateTimeStamp lexical representations. #639
base: main
Are you sure you want to change the base?
Conversation
I had to disable the |
…ime and dateTimeStamp. Fixes #638
9af0eee
to
ae0e95b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving to unblock other work, but the failure of ecdsa_secp256r1_2020
is worrying.
It looks like just adding https://w3id.org/security/v2
to the context fixes the test, but something larger seems to be at play. I would suggest uncommenting the test with this fix, and have follow-ups for:
- addressing the Clippy warnings from Rust 1.82
- investigating this context issue, and either have a fix or determine if it's not a big deal as it's an old cryptosuite
Description
Adds a
Lexical<T>
wrapper type that preserves the lexical representation ofxsd_types::DateTime
andxsd_types::DateTimeStamp
.Also bumps
json-ld
to version 0.21.2, making sure that typed string literals are not canonicalized.Other changes
Pinned Rust version to 1.81.0 in the CI, to avoid clippy warnings.
Tested
Lexical<T>
.