Merge pull request #10 from spryker/feature/acp-3468/master-adjusted-…

…transfer-set-data-1 ACP-3468: Added additional payment data to payment entity
spryker · Jul 23, 2024 · 072ca3d · 072ca3d
2 parents 64291f2 + 147e601
commit 072ca3d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml b/src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml
@@ -122,7 +122,7 @@
         <property name="redirectSuccessUrl" type="string"/>
         <property name="redirectCancelUrl" type="string"/>
         <property name="additionalPaymentData" type="array" associative="true" singular="additionalPaymentDatum"/>
-        <property name="details" type="array" associative="true" singular="detail"/>
+        <property name="details" type="string"/>
     </transfer>
 
     <transfer name="PaymentRefund" strict="true">

diff --git a/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php b/src/Spryker/Zed/AppPayment/Persistence/Propel/Payment/Mapper/PaymentMapper.php
@@ -21,23 +21,19 @@ public function mapPaymentTransferToPaymentEntity(PaymentTransfer $paymentTransf
     {
         $quoteTransfer = $paymentTransfer->getQuoteOrFail();
         $quoteJson = json_encode($quoteTransfer->toArray());
-        $details = json_encode($paymentTransfer->getDetails() ?? []);
 
         $paymentData = $paymentTransfer->modifiedToArray();
         $paymentData[PaymentTransfer::QUOTE] = $quoteJson;
-        $paymentData[PaymentTransfer::DETAILS] = $details;
 
         return $spyPayment->fromArray($paymentData);
     }
 
     public function mapPaymentEntityToPaymentTransfer(SpyPayment $spyPayment, PaymentTransfer $paymentTransfer): PaymentTransfer
     {
         $quoteData = json_decode((string)$spyPayment->getQuote(), true);
-        $details = json_decode((string)$spyPayment->getDetails(), true);
 
         $paymentData = $spyPayment->toArray();
         $paymentData[PaymentTransfer::QUOTE] = $quoteData;
-        $paymentData[PaymentTransfer::DETAILS] = $details;
 
         return $paymentTransfer->fromArray($paymentData, true);
     }

diff --git a/tests/_data/app_payment.databuilder.xml b/tests/_data/app_payment.databuilder.xml
@@ -9,7 +9,7 @@
     <transfer name="Payment" strict="true">
         <property name="redirectSuccessUrl" dataBuilderRule="url()"/>
         <property name="redirectCancelUrl" dataBuilderRule="url()"/>
-        <property name="details" dataBuilderRule="shuffle(array())"/>
+        <property name="details" dataBuilderRule="={}"/>
     </transfer>
 
     <transfer name="PaymentRefund" strict="true">