Feature/acp 4656/master adjust event status payment history #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and PaymentUpdated messages.
…e structure used on SCCOS side.
matweew
reviewed
Jan 8, 2025
| </transfer> | ||
|
|
||
| <transfer name="PaymentStatusHistoryCollection" strict="true"> | ||
| <property name="paymentStatusHistory" type="PaymentStatusHistory[]" singular="paymentStatusHistory"/> |
There was a problem hiding this comment.
Suggested change
| <property name="paymentStatusHistory" type="PaymentStatusHistory[]" singular="paymentStatusHistory"/> | |
| <property name="paymentStatusHistoryItems" type="PaymentStatusHistory[]" singular="paymentStatusHistoryItem"/> |
There was a problem hiding this comment.
I was also thinking about a different name here. "Item" reminds me too much of an order item. How about using just PaymentStatus and PaymentStatusHistory? The latter is the collection and the first is an "item" in the history.
I will go for it.
There was a problem hiding this comment.
Applied, looks much more natural now. The PaymentStatusHistory implies already that it is a collection that contains PaymentStates aka PaymentStatusTransfer's.
src/Spryker/Shared/AppPayment/Transfer/app_payment.transfer.xml
Outdated
Show resolved
Hide resolved
matweew
approved these changes
Jan 9, 2025
stereomon
deleted the
feature/acp-4656/master-adjust-event-status-payment-history
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCCOS Sales Detail Page with changes down below: