ACP-2626 Return error response in case of no handler was executed. (#2)

spryker · Jul 17, 2024 · a55934a · a55934a
1 parent 37b186f
commit a55934a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/Spryker/Zed/AppWebhook/Business/WebhookHandler/WebhookHandler.php b/src/Spryker/Zed/AppWebhook/Business/WebhookHandler/WebhookHandler.php
@@ -29,6 +29,12 @@ public function handleWebhook(WebhookRequestTransfer $webhookRequestTransfer, We
             $webhookResponseTransfer = $webhookHandlerPlugin->handleWebhook($webhookRequestTransfer, $webhookResponseTransfer);
         }
 
+        if ($webhookResponseTransfer->getIsSuccessful() === null) {
+            $webhookResponseTransfer
+                ->setIsSuccessful(false)
+                ->setMessage(sprintf('The webhook was not handled by any of the registered plugins. WebhookRequestTransfer: %s', json_encode($webhookRequestTransfer->toArray())));
+        }
+
         return $webhookResponseTransfer;
     }
 }
diff --git a/tests/SprykerTest/Glue/AppWebhookBackendApi/RestApi/AppWebhookApiTest.php b/tests/SprykerTest/Glue/AppWebhookBackendApi/RestApi/AppWebhookApiTest.php
@@ -54,6 +54,24 @@ public function testGivenAGlueRequestWithoutContentWhenTheRequestIsHandledThenAH
         $this->assertSame('POST content is required.', $glueResponseTransfer->getErrors()[0]->getMessage());
     }
 
+    public function testGivenAValidGlueRequestWhenTheRequestIsNotHandledByAnyOfTheAttachedPluginsThenAnExceptionIsThrownHttpStatus400IsReturnedTogetherWithAMessageInTheGlueResponseTransfer(): void
+    {
+        // Arrange
+        $glueRequestTransfer = new GlueRequestTransfer();
+        $glueRequestTransfer
+            ->setContent('{"key": "value"}')
+            ->setPath('/webhooks');
+
+        $webhooksController = new WebhooksController();
+
+        // Act
+        $glueResponseTransfer = $webhooksController->postAction($glueRequestTransfer);
+
+        // Assert
+        $this->assertSame(Response::HTTP_BAD_REQUEST, $glueResponseTransfer->getHttpStatus());
+        $this->assertCount(1, $glueResponseTransfer->getErrors());
+    }
+
     public function testGivenAValidGlueRequestWhenTheRequestIsHandledAndTheWebhookResponseIsSuccessfulThenAHttpStatus200IsReturnedInTheGlueResponseTransfer(): void
     {
         // Arrange