Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error processing and service naming #7

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Improved error processing and service naming #7

merged 3 commits into from
Dec 20, 2024

Conversation

gechetspr
Copy link
Contributor

@gechetspr gechetspr added the improvement New feature or request label Dec 20, 2024
dimitriyTsemma
dimitriyTsemma previously approved these changes Dec 20, 2024
View reviewed changes
@annakotiuk
Copy link

Validations are red

@gechetspr
Copy link
Contributor Author

Validation is red and this is expected due to missing a proper PHP image with required extensions

@annakotiuk
Copy link

Is validation error here https://release.spryker.com/integration/view/spryker/opentelemetry/0c6136ae085629a584f575f01d60f0966f0f0492 expected?

@gechetspr
Copy link
Contributor Author

yes. Spryker CV validation red is also expected

@gechetspr gechetspr merged commit 1352af1 into master Dec 20, 2024
0 of 4 checks passed
@gechetspr gechetspr deleted the feature/error-handling-optimisation branch December 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakotiuk annakotiuk annakotiuk approved these changes

@asmarovydlo asmarovydlo asmarovydlo approved these changes

@dimitriyTsemma dimitriyTsemma dimitriyTsemma left review comments

Assignees
No one assigned
Labels
improvement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gechetspr @annakotiuk @asmarovydlo @dimitriyTsemma