TE-10370 Fix up cloaking checks that are not needed. (#8983)

* TE-10370 Fix up cloaking checks that are not needed. * TE-10370 Manually fix up remaining cloaking checks that are not needed. * TE-10370 Manually fix up remaining cloaking checks that are not needed. * Remove code smell and phpstan issue.
spryker · Dec 28, 2021 · 942d370 · 942d370
1 parent b64385a
commit 942d370
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...er/Zed/ProductList/Business/ProductListRestrictionFilter/ProductListRestrictionFilter.php b/...er/Zed/ProductList/Business/ProductListRestrictionFilter/ProductListRestrictionFilter.php
@@ -34,20 +34,20 @@ public function __construct(
      */
     public function filterRestrictedProductConcreteSkus(array $productConcreteSkus, array $customerBlacklistIds, array $customerWhitelistIds): array
     {
-        if (empty($productConcreteSkus)) {
+        if (!$productConcreteSkus) {
             return [];
         }
 
         $restrictedProductConcreteSkus = [];
 
-        if (!empty($customerWhitelistIds)) {
+        if ($customerWhitelistIds) {
             $productConcreteSkusInWhitelist = $this->productListReader
                 ->getProductConcreteSkusInWhitelists($productConcreteSkus, $customerWhitelistIds);
 
             $restrictedProductConcreteSkus = array_diff($productConcreteSkus, $productConcreteSkusInWhitelist);
         }
 
-        if (!empty($customerBlacklistIds)) {
+        if ($customerBlacklistIds) {
             $productConcreteSkusInBlacklist = $this->productListReader
                 ->getProductConcreteSkusInBlacklists($productConcreteSkus, $customerBlacklistIds);
 

diff --git a/.../ProductList/Business/ProductListRestrictionValidator/ProductListRestrictionValidator.php b/.../ProductList/Business/ProductListRestrictionValidator/ProductListRestrictionValidator.php
@@ -70,7 +70,7 @@ public function validateItemAddition(CartChangeTransfer $cartChangeTransfer): Ca
                 $customerWhitelistIds,
             );
 
-        if (empty($restrictedProductConcreteSkus)) {
+        if (!$restrictedProductConcreteSkus) {
             return $cartPreCheckResponseTransfer;
         }
 

diff --git a/src/Spryker/Zed/ProductList/Business/RestrictedItemsFilter/RestrictedItemsFilter.php b/src/Spryker/Zed/ProductList/Business/RestrictedItemsFilter/RestrictedItemsFilter.php
@@ -79,7 +79,7 @@ protected function removeRestrictedItemsFromQuote(
         array $blacklistIds,
         array $whitelistIds
     ): void {
-        if (empty($blacklistIds) && empty($whitelistIds)) {
+        if (!$blacklistIds && !$whitelistIds) {
             return;
         }
 
@@ -89,7 +89,7 @@ protected function removeRestrictedItemsFromQuote(
 
         $restrictedProductConcreteSkus = $this->productListRestrictionFilter->filterRestrictedProductConcreteSkus($quoteSkus, $blacklistIds, $whitelistIds);
 
-        if (empty($restrictedProductConcreteSkus)) {
+        if (!$restrictedProductConcreteSkus) {
             return;
         }
 

diff --git a/src/Spryker/Zed/ProductList/Persistence/ProductListRepository.php b/src/Spryker/Zed/ProductList/Persistence/ProductListRepository.php
@@ -209,11 +209,11 @@ public function getProductConcreteProductListIdsForType(int $idProduct, string $
      */
     protected function getConcreteProductSkusInList(array $productConcreteSkus, string $listType, array $productListIds): array
     {
-        if (empty($productConcreteSkus)) {
+        if (!$productConcreteSkus) {
             return [];
         }
 
-        if (empty($productListIds)) {
+        if (!$productListIds) {
             return [];
         }