FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. #958

aleksandr-velikanov · 2024-09-26T12:19:45Z

Developer(s): @aleksandr-velikanov
Ticket: https://spryker.atlassian.net/browse/FRW-6354

Change log

Improvements

Added Zed: assign store to category step.
Included it into the Dynamic_multistore test

annakotiuk · 2024-09-26T16:25:07Z

robot - files - is it about tests?

AntonShopin

Please add tests for all 5 applications and not only for suite.

AntonShopin · 2024-09-26T16:21:58Z

resources/common/common_zed.robot

@@ -16,7 +16,7 @@ ${zed_variant_search_field_locator}     xpath=//*[@id='product-variant-table_fil
 ${zed_processing_block_locator}     xpath=//div[contains(@id,'processing')][contains(@class,'dataTables_processing')]
 ${zed_merchants_dropdown_locator}    xpath=//select[@name='id-merchant']
 ${zed_attribute_access_denied_header}    xpath=//div[@class='wrapper wrapper-content']//div[@class='flash-messages']//following-sibling::h1
-
+${zed_category_save_button}     xpath=//button[contains(@class,'safe-submit')]


Looks like this locator is specific to Edit Category page, but locators in this file are general for many pages in Zed.
In this case please create a new zed_edit_category_page.robot file in https://github.com/spryker/robotframework-suite-tests/tree/master/resources/pages/zed and move it there

AntonShopin · 2024-09-26T16:23:08Z

resources/steps/zed_store_steps.robot

@@ -54,6 +54,8 @@ Zed: create new Store:
        END         
    END 
    Click    ${zed_store_save_button}
+    wait until element is visible    ${zed_success_flash_message}


Suggested change

wait until element is visible ${zed_success_flash_message}

Wait Until Element Is Visible ${zed_success_flash_message}

AntonShopin · 2024-09-26T16:28:38Z

tests/ui/suite/multistore/mustistore.robot

@@ -296,6 +297,7 @@ Dynamic_multistore
    Zed: login on Zed with provided credentials:    ${zed_admin_email}
    Zed: assigned store to cms block:    ${random_str_store}_${random_str_store}    customer-registration_token--html
    Zed: assigned store to cms block:    ${random_str_store}_${random_str_store}    customer-registration_token--text
+    Zed: assign store to category:    ${random_str_store}


You assign a category to the newly created store, but there is no assertion that this new Category is available on the newly created store.

So for this case you need to

Assign category to store in Zed

Trigger P&S as in CI env we don't have Jenkins. Trigger can be done by Trigger multistore p&s keyword (see above in this test)

Check that the category is available in the store, to which it was assigned. Here I advice you to check through the API call and not though the UI

Here I'm not sure this is within the scope of the ticket (https://spryker.atlassian.net/browse/FRW-6354). The adjustment was only concerning the UI, and I'd rather not widen the scope to include the API

Disagree.
Previously it was not possible to assign category to a newly created store, so we didn't know if it works at all.
The score of the bug ticket is not just to fix the UI but also to check that category is available for the customers after store assignment.

Imagine if UI in the back-office is fixed but the category is still not accessible on the storefront/API - what is the value of this fix in such case?

Agreed, will update accordingly

AntonShopin · 2024-09-26T16:29:24Z

tests/ui/suite/multistore/mustistore.robot

@@ -296,6 +297,7 @@ Dynamic_multistore
    Zed: login on Zed with provided credentials:    ${zed_admin_email}
    Zed: assigned store to cms block:    ${random_str_store}_${random_str_store}    customer-registration_token--html
    Zed: assigned store to cms block:    ${random_str_store}_${random_str_store}    customer-registration_token--text
+    Zed: assign store to category:    ${random_str_store}


You assign a category to the newly created store, but there is no assertion that this new Category is available on the newly created store.

So for this case you need to

Assign category to store in Zed

Trigger P&S as in CI env we don't have Jenkins. Trigger can be done by Trigger multistore p&s keyword (see above in this test)

Check that the category is available in the store, to which it was assigned. Here I advice you to check through the API call and not though the UI

AntonShopin · 2024-09-26T16:32:50Z

resources/steps/zed_catalog_category_steps.robot

+    [Arguments]    ${store}
+    Zed: go to second navigation item level:    Catalog    Category
+    Zed: click Action Button in a table for row that contains:     cables     Edit
+    Click    xpath=//body/ul[@class='dropdown-menu']/li/a[contains(.,'Edit')]


xpath=//body/ul[@class='dropdown-menu']/li/a[contains(.,'Edit')] looks like a static locator. Don't hardcode it right in the keyword. Please move it to a separate page that describes elements of this page and use a variable in your keyword

AntonShopin · 2024-09-26T16:33:27Z

resources/steps/zed_catalog_category_steps.robot

+    Zed: click Action Button in a table for row that contains:     cables     Edit
+    Click    xpath=//body/ul[@class='dropdown-menu']/li/a[contains(.,'Edit')]
+    Set Browser Timeout    ${browser_timeout}
+    Wait Until Element Is Visible    xpath=//select[@id="category_store_relation_id_stores"]


same here, don't hardcode static locators in keywords. Thanks

AntonShopin · 2024-09-26T16:43:50Z

resources/steps/zed_catalog_category_steps.robot

+Zed: assign store to category:
+    [Arguments]    ${store}
+    Zed: go to second navigation item level:    Catalog    Category
+    Zed: click Action Button in a table for row that contains:     cables     Edit


cables is hardcoded inside the keyword.

add new argument to this keywrod so it accepts the category and store as a variable

create new variable in all these 5 files with a values of categories that you'd like to edit within your tests. In these files we store environment specific data, as suite, b2b and b2c demodata is different. Use newly created variable in the test file to pass the value of the category to edit

https://github.com/spryker/robotframework-suite-tests/blob/master/resources/environments/environments_ui_b2b.json

https://github.com/spryker/robotframework-suite-tests/blob/master/resources/environments/environments_ui_b2c.json

https://github.com/spryker/robotframework-suite-tests/blob/master/resources/environments/environments_ui_mp_b2b.json

https://github.com/spryker/robotframework-suite-tests/blob/master/resources/environments/environments_ui_mp_b2c.json

https://github.com/spryker/robotframework-suite-tests/blob/master/resources/environments/environments_ui_suite.json

aleksandr-velikanov added 7 commits September 25, 2024 20:04

FRW-6354 Add steps for category edit

0b9c646

FRW-6354 Add success message check for store creation

261032b

FRW-6354 Update steps

8aebc45

FRW-6354 Use variable

5755fc8

FRW-6354 Add import

247cae8

FRW-6354 Use variable

097bc46

FRW-6354 Use variable

849e626

aleksandr-velikanov requested a review from AntonShopin September 26, 2024 12:19

aleksandr-velikanov self-assigned this Sep 26, 2024

aleksandr-velikanov changed the title ~~Bugfix/frw 6354/dms cannot assign category to a new store~~ FRW-6354 Fix Edit Category page so that any store can be assigned to a category. Sep 26, 2024

FRW-6354 Add call to Dynamic_multistore test

55c377c

aleksandr-velikanov changed the title ~~FRW-6354 Fix Edit Category page so that any store can be assigned to a category.~~ FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. Sep 26, 2024

annakotiuk previously approved these changes Sep 26, 2024

View reviewed changes

AntonShopin requested changes Sep 26, 2024

View reviewed changes

aleksandr-velikanov added 10 commits October 1, 2024 16:39

FRW-6354 Add category store check

db6ab09

FRW-6354 Use variables

44095f7

FRW-6354 Use env variables

e906fc1

FRW-6354 Add bapi tag

d4c18de

FRW-6354 Use env var

8708fac

FRW-6354 Cleanup

cd92ec3

FRW-6354 Use vars, add P&S

c268853

FRW-6354 Update check

5ebea61

FRW-6354 Add param

24b18e3

FRW-6354 Use demoshop as default category

dd938ae

aleksandr-velikanov dismissed annakotiuk’s stale review via dd938ae October 18, 2024 10:16

FRW-6354 Update conditions

6ccbb0b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. #958

FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. #958

aleksandr-velikanov commented Sep 26, 2024

annakotiuk commented Sep 26, 2024

AntonShopin left a comment

AntonShopin Sep 26, 2024

AntonShopin Sep 26, 2024

AntonShopin Sep 26, 2024

aleksandr-velikanov Sep 26, 2024

AntonShopin Sep 26, 2024

aleksandr-velikanov Sep 26, 2024

AntonShopin Sep 26, 2024

AntonShopin Sep 26, 2024

AntonShopin Sep 26, 2024

AntonShopin Sep 26, 2024

	wait until element is visible ${zed_success_flash_message}
	Wait Until Element Is Visible ${zed_success_flash_message}

FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. #958

Are you sure you want to change the base?

FRW-6354 Fixed Edit Category page so that any store can be assigned to a category. #958

Conversation

aleksandr-velikanov commented Sep 26, 2024

Change log

annakotiuk commented Sep 26, 2024

AntonShopin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment