Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRW-9013 Updated customer management integration guide. #2958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FRW-9013 Updated customer management integration guide. #2958

wants to merge 1 commit into from

Conversation

kraal-spryker
Copy link
Contributor

@kraal-spryker kraal-spryker added the updated PR contains meaningful changes to some document label Dec 4, 2024
@kraal-spryker kraal-spryker changed the title FRW-9013: update customer management integration guide FRW-9013 Updated customer management integration guide. Dec 4, 2024
gechetspr
gechetspr reviewed Dec 4, 2024
View reviewed changes
_includes/pbc/all/install-features/202410.0/install-the-customer-account-management-feature.md
@@ -131,6 +131,27 @@ class CustomerConfig extends SprykerCustomerConfig
}
```

4. Optional: To speed-up the query response time for the customer registration, adjust the `CustomerConfig::isCustomerEmailValidationCaseSensitive()` to return `true`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please describe drawbacks of this action if we have any

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no drawbacks, just query response time optimisation, which was already described

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention that this is required to be set to false on "big" production databases, where the amount of customers is more than 1k (guesstimate), we also should explain what is the difference in behaviour here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gechetspr gechetspr gechetspr left review comments

@ishakuta ishakuta ishakuta left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
updated PR contains meaningful changes to some document
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraal-spryker @ishakuta @gechetspr