-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Decoupling of Checkout endpoint and OMS commands to architectur… #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-performance-guidelines.md
vitaliiivanovspryker
added
the
updated
PR contains meaningful changes to some document
label
Dec 12, 2024
profuel
reviewed
Dec 12, 2024
docs/dg/dev/guidelines/performance-guidelines/architecture-performance-guidelines.md
Outdated
Show resolved
Hide resolved
docs/dg/dev/guidelines/performance-guidelines/architecture-performance-guidelines.md
Outdated
Show resolved
Hide resolved
docs/dg/dev/guidelines/performance-guidelines/architecture-performance-guidelines.md
Outdated
Show resolved
Hide resolved
docs/dg/dev/guidelines/performance-guidelines/architecture-performance-guidelines.md
Outdated
Show resolved
Hide resolved
docs/dg/dev/guidelines/performance-guidelines/architecture-performance-guidelines.md
Outdated
Show resolved
Hide resolved
text improvements Co-authored-by: Andrey Tkachenko <[email protected]>
profuel
previously approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
TW review needed
PR needs Technical writer's review
updated
PR contains meaningful changes to some document
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.
Steps before you submit a PR
contribution-license-agreement.txt
file with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/spryker-docs/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.
This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH
is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist