improved phpstan.md article #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliiivanovspryker
added
the
updated
matweew
reviewed
Dec 17, 2024
|
|
||
| {% info_block errorBox %} | ||
|
|
||
| Note that running this command with the level 2 key (**-l 2**) and having no errors is obligatory, and having no errors with level 5 (**-l 5**) is highly recommended. | ||
| By default, Spryker demo shops are configured with PHPStan at level 6 in the `phpstan.neon` file, which is the highly recommended configuration for Spryker projects. |
There was a problem hiding this comment.
if the level is 6 in phpstan.neon, -l 6 is not needed in the command
There was a problem hiding this comment.
It's not needed but I would leave it as an example and make it more obvious
matweew
previously approved these changes
Jan 6, 2025
|
|
||
| ### ./[ROOT]/phpstan.neon | ||
|
|
||
|
|
There was a problem hiding this comment.
Add a description here
There was a problem hiding this comment.
extra line was removed
There was a problem hiding this comment.
I added the extra line to leave a comment. Please add the descriptions
There was a problem hiding this comment.
I can not get what kind of a description honestly
This part of the file was not touched with MR
| @@ -83,6 +97,7 @@ services: | |||
|
|
|||
| ### ./[Module]/phpstan.neon | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Add a description here
There was a problem hiding this comment.
extra line was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.
Steps before you submit a PR
contribution-license-agreement.txtfile with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/spryker-docs/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCHis a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist