Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility for changes introduced in 1.14.0 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiborbuzasi
Copy link

@tiborbuzasi tiborbuzasi commented Dec 7, 2022

Doing a Spryker upgrade caused can('SeePricePermissionPlugin') in Twig always return false.

After hours of debugging we narrowed down the issue to the update of the spryker/synchronization package.

If $keySuffix is an empty string in DefaultKeyGeneratorPlugin::generateKey()

  • prior to 1.14.0 the returned value was $this->getResource() e.g. resource
  • after 1.14.0 the returned value is sprintf('%s:%s', $this->getResource(), $keySuffix) e.g. resource:

for changes introduced in 1.14.0
@spryker-release-bot
Copy link
Collaborator

Thank you for providing a pull request to our repository. Can we ask you to complete this 2-question form?
https://www.surveymonkey.de/r/PPNJ5L8

This will help us evaluate and merge your pull request as soon as possible, as well as make sure your contribution is properly recognized.
After sending your answer, our developers will check your PR and reach out to you using the email provided below with clarifying questions and an ETA on when you can expect your contribution to be merged with our core code.

In the meantime, please check that:

  • Your code is free of side effects that could harm other use cases.
  • Your code is tested, ideally a small test case provided along side the change to show the issue is indeed fixed and no regression can sneak in.

With this we can process it even faster and will be able to deliver the fixed module(s) to you with highest quality.

@dereuromark
Copy link
Contributor

1.13.1...1.14.0#diff-170b73375ea459d71f752906645a9eeb02bef3021504dc91ab3498e3763a98f2L46-L48 indeed did remove that part as part of the return not supposed to be empty according to static analyzers.
We will have to revert this then.

@gechetspr
Copy link
Contributor

Thank you for the PR! We will take it in process and will ping you in this PR when we release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants