Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastFollow to PR:541 #542

Merged
merged 5 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,6 @@ jobs:

- name: Build & Test
run: tuist test --path SampleApp --os ${{ matrix.sdk }} UnitTests -- -resultBundlePath TestResult

- name: Archive TestResult
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: TestResult.xcresult
path: TestResult.xcresult

- name: Package snapshot changes
if: ${{ failure() }}
Expand All @@ -82,3 +75,10 @@ jobs:
with:
name: snapshot_changes_${{ matrix.sdk }}
path: snapshot_changes_${{ matrix.sdk }}.tar

- name: Archive TestResult
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: TestResult.xcresult
path: TestResult.xcresult
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ extension UIAccessibilityTraits {
/// (lldb) po String(134217728, radix: 2).count - 1
/// 27
/// ```
public static let backButton: UIAccessibilityTraits = UIAccessibilityTraits(rawValue: 1 << 27)
package static let backButton: UIAccessibilityTraits = UIAccessibilityTraits(rawValue: 1 << 27)


/// `UIAccessibilityTraits` contains a trait that is used on `UISwitch`
/// prior to iOS 17 this trait was private but was later exposed as `.toggleButton`.
/// We will reference the trait by its raw value but provide an alternative name to avoid conflicting with the public trait .
///
public static let _toggleButton = UIAccessibilityTraits(rawValue: 1 << 53)
package static let _toggleButton = UIAccessibilityTraits(rawValue: 1 << 53)
}
21 changes: 0 additions & 21 deletions BlueprintUI/UITests/AccessibilityTests.swift

This file was deleted.

46 changes: 0 additions & 46 deletions BlueprintUI/UITests/PostsTests.swift

This file was deleted.

2 changes: 1 addition & 1 deletion BlueprintUI/UITests/UIAccessibililtyTraitsTests.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import BlueprintUI
import UIKit
import XCTest
@testable import BlueprintUI


class UIAccessibilityTraits_Tests: XCTestCase {
Expand Down
22 changes: 22 additions & 0 deletions BlueprintUI/UITests/UITestHost/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import UIKit

@UIApplicationMain
final class AppDelegate: UIResponder, UIApplicationDelegate {

var window: UIWindow?


func application(
_ application: UIApplication,
didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
) -> Bool {

window = UIWindow(frame: UIScreen.main.bounds)
window?.rootViewController = UIViewController()
window?.makeKeyAndVisible()

return true
}

}

6 changes: 5 additions & 1 deletion SampleApp/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ let project = Project(
name: "Tutorial 2 (Completed)",
sources: ["Tutorials/Tutorial 2 (Completed)/**"]
),
.app(
name: "UITestHost",
sources: ["../BlueprintUI/UITests/UITestHost/**"]
),

// These tests are duplicates of the test definitions in the root Package.swift, but Tuist
// does not currently support creating targets for tests in SwiftPM dependencies. See
Expand All @@ -44,7 +48,7 @@ let project = Project(
bundleId: "$(inherited).UITests",
deploymentTargets: .iOS("15.0"),
sources: ["../BlueprintUI/Tests/Extensions/**", "../BlueprintUI/UITests/**"],
dependencies: [.target(name: "SampleApp")]
dependencies: [.target(name: "UITestHost")]
),

.unitTest(
Expand Down
Loading