Correcting sample code snippet in Tutorial 5 #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,9 +75,7 @@ object WelcomeWorkflow : StatefulWorkflow<Unit, State, LoggedIn, WelcomeScreen>( | |||
| } | |||
There was a problem hiding this comment.
looks like more needs to be changed here. This is still using name rather than username
There was a problem hiding this comment.
Yes @steve-the-edwards you are right, updated with username just now. I also forget to update line Thanks!323, it is now updated as well.
steve-the-edwards
approved these changes
Oct 24, 2023
steve-the-edwards
force-pushed
the
update-tutorial-5-to-correct-minor-errors
branch
from
0300e95 to
4082ace
Compare
steve-the-edwards
force-pushed
the
update-tutorial-5-to-correct-minor-errors
branch
from
4082ace to
3469ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Tutorial5.md, there was an oversight in the code example forWelcomeWorkflow#onLogin. The example incorrectly included theisNotEmpty()check before it was supposed to be added by the developer. Additionally, it had an incorrect variable name,state.name, which has been corrected tostate.username.This pull request removes the
isNotEmpty()check and makes the necessary variable name correction.Thank you!