Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves legibility of Compatible.keyFor, NamedScreen, Named. #1113

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Oct 4, 2023

This:

object Hey : Screen
NamedScreen(NamedScreen(Hey, "one"), "ho")

is now logged as this:

NamedScreen:ho(NamedScreen:one(com.squareup.workflow1.ui.NamedScreenTest$Hey))

instead of this:

com.squareup.workflow1.ui.NamedScreenTest$Hey+NamedScreen(one)+NamedScreen(ho)

This:

```
object Hey : Screen
NamedScreen(NamedScreen(Hey, "one"), "ho")
```

is now logged as this:

```
NamedScreen:ho(NamedScreen:one(com.squareup.workflow1.ui.NamedScreenTest$Hey))
```

instead of this:

```
com.squareup.workflow1.ui.NamedScreenTest\$Hey+NamedScreen(one)+NamedScreen(ho)
```
@rjrjr rjrjr marked this pull request as ready for review October 4, 2023 18:05
@rjrjr rjrjr requested review from zach-klippenstein and a team as code owners October 4, 2023 18:05
@rjrjr rjrjr merged commit 0a14ba0 into main Oct 5, 2023
31 checks passed
@rjrjr rjrjr deleted the ray/invert-keyFor branch October 5, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants