Updates: Gradle 8.4; AGP 8.1.2; Java 17; Remove Kotlin DSL Plugin Use #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
rick/no_kotlin_dsl
branch
from
9c2792d to
1d3bacf
Compare
Update github actions to use Java 17 accordingly.
steve-the-edwards
force-pushed
the
rick/no_kotlin_dsl
branch
from
1d3bacf to
b3224fc
Compare
steve-the-edwards
force-pushed
the
rick/no_kotlin_dsl
branch
from
e780d42 to
0218aca
Compare
steve-the-edwards
changed the title
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
steve-the-edwards
force-pushed
the
rick/no_kotlin_dsl
branch
from
eb56826 to
37d9793
Compare
rjrjr
approved these changes
Oct 20, 2023
| @@ -1,7 +1,8 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
So if we've removed this plugin, how is it that the *.kts files are still working?
There was a problem hiding this comment.
Is the idea that *.kts support is intrinsic, and the plugin is required just to extend it?
There was a problem hiding this comment.
Yes, I thought the same as you that we would have migrated back to pure .gradle files in Groovy, but @RBusarow explained that the kotlin-dsl plugin just extends it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit too coupled but it builds 🤷🏻