Update Kotlin 1.9 (and friends) #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force kotlin 1.9 in build logic so that while using plugins that default to what is already being used they won't leak in previous versions.
steve-the-edwards
force-pushed
the
sedwards/update-kotlin-1.9
branch
2 times, most recently
from
b392ed0 to
96b822a
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/update-kotlin-1.9
branch
from
96b822a to
f4b6ccb
Compare
rjrjr
approved these changes
Oct 23, 2023
| @@ -1,3 +1,8 @@ | |||
| plugins { | |||
| // Hardcoded as this is upstream of the version catalog. Keep this in sync with that. | |||
There was a problem hiding this comment.
Is there a comment there pointing back at this?
There was a problem hiding this comment.
No, there wasn't but that's a good point. Adding now in gradle/libs.versions.toml:
# Keep this in sync with what is hard-coded in build-logic/settings.gradle.kts as that is upstream
# of loading the library versions from this file but should be the same.
kotlin = "1.9.10"
f4b6ccb to
3524e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Kotlin 1.9 and other dependencies - e.g. Compose compiler, ktlint, etc.
Use Kotlin/JS (IR) for the Kotlin/JS
Run udpated dependencyGuardBaseline and ktlint format
Removed
ktlint_code_style = officialas that is no longer an option.