revert jdk target to 1.8 #1133
Merged
revert jdk target to 1.8 #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
approved these changes
Oct 25, 2023
RBusarow
force-pushed
the
rick/better-java-version-handling
branch
from
5154adf to
b3979e9
Compare
rjrjr
approved these changes
Oct 25, 2023
| @@ -13,12 +15,12 @@ android { | |||
| compileSdk = libsCatalog.version("compileSdk").toInt() | |||
|
|
|||
| compileOptions { | |||
| sourceCompatibility = JavaVersion.VERSION_17 | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| sourceCompatibility = javaTargetVersion | |||
There was a problem hiding this comment.
Do we really need to change sourceCompatilibity too? Will that, say, prevent us using language features that aren't actually supported?
There was a problem hiding this comment.
That's correct keeping them in sync will prevent us from inadvertently using Java language features that don't exist in the target environment.
rjrjr
reviewed
Oct 25, 2023
| @@ -44,3 +27,48 @@ fun DependencyHandler.kotlin( | |||
| module: String, | |||
| version: String? = null | |||
| ): Any = "org.jetbrains.kotlin:kotlin-$module${version?.let { ":$version" } ?: ""}" | |||
|
|
|||
| /** | |||
| * the jdk used in packaging | |||
There was a problem hiding this comment.
I'd thought it was, but sadly no. The catalog entry/property names are unique to individual projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.