Add testRender with CoroutineScope for SessionWorkflow #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
steve-the-edwards
force-pushed
the
sedwards/test-render-session
branch
2 times, most recently
from
a4dca45 to
ada7b66
Compare
rjrjr
approved these changes
Dec 11, 2023
| @Suppress("UNCHECKED_CAST") | ||
| public fun <PropsT, OutputT, RenderingT> Workflow<PropsT, OutputT, RenderingT>.testRender( | ||
| props: PropsT | ||
| ): RenderTester<PropsT, *, OutputT, RenderingT> { | ||
| val statefulWorkflow = asStatefulWorkflow() as StatefulWorkflow<PropsT, Any?, OutputT, RenderingT> | ||
| return statefulWorkflow.testRender( | ||
| props = props, | ||
| initialState = statefulWorkflow.initialState(props, null) | ||
| initialState = run { | ||
| require(this !is SessionWorkflow<PropsT, *, OutputT, RenderingT>) { |
| */ | ||
| @OptIn(WorkflowExperimentalApi::class) | ||
| @Suppress("UNCHECKED_CAST") | ||
| public fun <PropsT, OutputT, RenderingT> Workflow<PropsT, OutputT, RenderingT>.testRender( |
There was a problem hiding this comment.
Can't you make this version an extension on SessionWorkflow and avoid the runtime check?
There was a problem hiding this comment.
ya I thought about that but then I thought about how in your tests you might not have the reified SessionWorkflow type? Maybe you were passing it around or dealign with it just as a Workflow? Maybe I was overthinking it though. Perhaps we could just make it an extension on SessionWorkflow 🤔
There was a problem hiding this comment.
I think so. I'm going to write a unit test against class RealFooWorkflow, not interface FooWorkflow.
There was a problem hiding this comment.
ya, I think you are right. I will change it.
- testRender + CoroutineScope extension extends
SessionWorkflownotWorkflow
steve-the-edwards
force-pushed
the
sedwards/more-session-docs
branch
from
f756591 to
4bf0412
Compare
steve-the-edwards
force-pushed
the
sedwards/test-render-session
branch
from
9155c85 to
1a34138
Compare
steve-the-edwards
force-pushed
the
sedwards/test-render-session
branch
from
1a34138 to
c43729f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138