Fix what bounds gets reported in layered dialog sessions #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rjrjr
approved these changes
Jan 17, 2024
rjrjr
deleted the
kabdulla/fix-reported-bounds-layered-dialog-sessions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layered Dialog Sessions reports the bounds of views so that dialogs can place themselves correctly.
However, when this dialog get's animated we started noticing odd reported values ie)
things like
Rect(0, 4 - 1920, 1004),Rect(0, -416 - 1920, 584),Rect(0, -347 - 1920, 653).In order to guard against these, we ensure that the top of the rect report is at least equal or greater to the devices top-inset.