set GHA runner max heap size dynamically based upon runner hardware #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
approved these changes
Feb 2, 2024
| ;; | ||
| Windows) | ||
| jvmArgs="-Xmx3g -XX:MaxMetaspaceSize=756m $jvmArgs" | ||
| # Fetch and parse memory in MB, then convert to GB |
There was a problem hiding this comment.
Wow, are you actually set up to test this?
There was a problem hiding this comment.
ChatGPT was kind enough to show me how to do this. It does seem to work, but I do not take credit. :)
RBusarow
force-pushed
the
rick/dynamic-github-action-runner-memory
branch
from
a837ccc to
09c9cda
Compare
Before this change, we set the max heap size based upon runner OS. That worked well enough, since we only used the free GitHub-hosted runners with well-known hardware. Now that we have two different Ubuntu runner sizes, that older strategy is leaving free memory on the table.
RBusarow
force-pushed
the
rick/dynamic-github-action-runner-memory
branch
from
09c9cda to
ee46891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we set the max heap size based upon runner OS. That worked well enough, since we only used the free GitHub-hosted runners with well-known hardware.
Now that we have two different Ubuntu runner sizes, that old strategy is leaving free memory on the table.