always check out the github.head_ref in CI
#1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
force-pushed
the
rick/check-out-head_ref
branch
from
8ce3a87 to
53d01ee
Compare
The default behavior for the `actions/checkout` is to check out the `github.ref` commit. In the case of `pull_request_target` triggers, the `github.ref` commit is the last commit on the target branch (typically `main`), instead of the PR branch: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target > This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. Unfortunately, that means that unless we specify the correct PR branch, the `kotlin.yml` workflow jobs will just execute against the `main`.
RBusarow
force-pushed
the
rick/check-out-head_ref
branch
from
53d01ee to
b61c214
Compare
rjrjr
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior for the
actions/checkoutis to check out thegithub.refcommit.In the case of
pull_request_targettriggers, thegithub.refcommit is the last commit on the target branch (typicallymain), instead of the PR branch:https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
Unfortunately, that means that unless we specify the correct PR branch, the
kotlin.ymlworkflow jobs will just execute against themain.