BREAKING: Compose overhaul makes ViewEnvironment less in your face. #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/compose-local-view-env
branch
from
605b33b to
6f57480
Compare
rjrjr
changed the title
rjrjr
force-pushed
the
ray/compose-local-view-env
branch
2 times, most recently
from
b3f43e1 to
059b5e7
Compare
rjrjr
commented
Jun 25, 2024
workflow-ui/compose/src/main/java/com/squareup/workflow1/ui/compose/LocalWorkflowEnvironment.kt
Show resolved
Hide resolved
rjrjr
requested review from
ijwhelan,
wardellbagby,
steve-the-edwards and
vgonda
ekeitho
reviewed
Jun 28, 2024
...-ui/compose/src/main/java/com/squareup/workflow1/ui/compose/ScreenComposableFactoryFinder.kt
Outdated
Show resolved
Hide resolved
wardellbagby
approved these changes
Jun 28, 2024
...compose/src/main/java/com/squareup/workflow1/ui/compose/ViewEnvironmentWithComposeSupport.kt
Show resolved
Hide resolved
@wardellbagby I've kept this README up to date. |
* Introduces `LocalWorkflowEnvironment` and eliminates explicit `ViewEnvironment` parameters from `ScreenComposableFactory.Content`, `ComposeScreen.Content`, etc. It is put in place automatically by the default implementation of `ScreenComposableFactoryFinder`.
* Adds optional `CompositionRoot` argument to `ViewEnvironment.withComposeInteropSupport()`. `CompositionRoot` is our existing hook to ensure `CompositionLocal`s (e.g. for UI themes) are put in play above the `@Composable Content()` function invoked for any `Screen`.
* Replaces `ViewEnvironment.withCompositionRoot` with `@Composable fun ViewEnvironment.RootScreen`, as our preferred Compose-friendly alternative to `WorkflowLayout`
An `Activity` that uses `setContent {}` instead of `setContentView()` can now kick things off like so:
```kotlin
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
val environment : ViewEnvironment = ViewEnvironment.EMPTY +
// ...
.withComposeInteropSupport()
val rootScreen by RootWorkflow.renderAsState(
props = Unit,
onOutput = {},
)
setContent {
environment.RootScreen(rootScreen)
}
}
```
rjrjr
force-pushed
the
ray/compose-local-view-env
branch
from
059b5e7 to
6fb63df
Compare
|
@RBusarow any guesses as to why the checks aren't running on this PR? |
Maybe lingering effects from the earlier outage. Closed and opened to try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
LocalWorkflowEnvironmentand eliminates explicitViewEnvironmentparameters fromScreenComposableFactory.Content,ComposeScreen.Content, etc. It is put in place automatically by the default implementation ofScreenComposableFactoryFinder.Adds optional
CompositionRootargument toViewEnvironment.withComposeInteropSupport().CompositionRootis our existing hook to ensureCompositionLocals (e.g. for UI themes) are put in play above the@Composable Content()function invoked for anyScreen.Replaces
ViewEnvironment.withCompositionRootwith@Composable fun ViewEnvironment.RootScreen, as our preferred Compose-friendly alternative toWorkflowLayoutAn
Activitythat usessetContent {}instead ofsetContentView()can now kick things off like so: