Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes TextController support equals #1224

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Makes TextController support equals #1224

merged 1 commit into from
Oct 21, 2024

Conversation

jkwiz
Copy link
Collaborator

@jkwiz jkwiz commented Oct 21, 2024

Allows comparing TextController by the current textValue.

@jkwiz jkwiz marked this pull request as ready for review October 21, 2024 22:01
@jkwiz jkwiz requested review from zach-klippenstein and a team as code owners October 21, 2024 22:01
@rjrjr
Copy link
Contributor

rjrjr commented Oct 21, 2024

LGTM, but could you add a unit test?

@jkwiz jkwiz force-pushed the joshwilliams/text-controller-equals branch from 47d58ca to df5471e Compare October 21, 2024 22:19
@jkwiz jkwiz force-pushed the joshwilliams/text-controller-equals branch from df5471e to 59d76c0 Compare October 21, 2024 22:33
@jkwiz jkwiz enabled auto-merge October 21, 2024 22:33
@rjrjr rjrjr disabled auto-merge October 21, 2024 22:47
@rjrjr rjrjr merged commit 701f3fe into main Oct 21, 2024
29 checks passed
@rjrjr rjrjr deleted the joshwilliams/text-controller-equals branch October 21, 2024 22:47
@jkwiz jkwiz mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkwiz @rjrjr