action {}, eventHandler {} with no debugging name is deprecated
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...dungeon/timemachine/src/test/java/com/squareup/sample/timemachine/TimeMachineWorkflowTest.kt
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Show resolved
Hide resolved
Comment on lines
+191
to
+195
| public fun eventHandler( | ||
| // Type variance issue: https://github.com/square/workflow-kotlin/issues/891 | ||
| update: | ||
| WorkflowAction<@UnsafeVariance PropsT, StateT, @UnsafeVariance OutputT>.Updater.() -> Unit | ||
| ): () -> Unit = eventHandler("eventHandler", update) |
There was a problem hiding this comment.
why do we have to introduce these versions without the name parameter just to deprecate it? Is this about the way in which the deprecation detection works with the optional parameter?
| @@ -76,6 +76,16 @@ public abstract class StatefulWorkflow< | |||
| public inner class RenderContext internal constructor( | |||
| baseContext: BaseRenderContext<PropsT, StateT, OutputT> | |||
| ) : BaseRenderContext<@UnsafeVariance PropsT, StateT, @UnsafeVariance OutputT> by baseContext { | |||
| public inline fun <reified CurrentStateT : StateT & Any> safeEventHandler( | |||
There was a problem hiding this comment.
not sure I understand why this one isn't deprecated? (Or why its introduced?)
There was a problem hiding this comment.
Oops, lost the deprecation annotation. Thanks.
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/RenderWorkflowInTest.kt
Show resolved
Hide resolved
Logs of actions are nearly useless if they have no name. Let's stop making things so convenient that we go blind.
steve-the-edwards
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs of actions are nearly useless if they have no name. Let's stop making things so convenient that we go blind.