Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get the vehicle name from the vehicle_state #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: get the vehicle name from the vehicle_state #43

wants to merge 1 commit into from

Conversation

bdo
Copy link

@bdo bdo commented Nov 7, 2023 •
edited
Loading

Tesla removed the display_name property from the vehicle_data response. It is now found under under vehicle_state subsection of the vehicle_data response.

This PR addresses this issue.

Tests

  • Code tested on Connect IQ Device simulator with fenix 6® pro
  • App tested on real fenix 6® pro

Fixes #42

Before the fix

image

Error: Unhandled Exception
Exception: UnexpectedTypeException: Expected Number/Float/Boolean/Long/Double, given null
Stack: 
  - setText() at 704b03c0.mb:5530 0x300043fd 
  - onUpdate() at /Users/bdoncieu/projects/garmin-tesla/source/MainView.mc:115 0x1000122f 

Encountered app crash.

After the fix

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widget crashes on all Garmin devices
1 participant
@bdo