Skip to content

Commit

Permalink
Add 2.10.0 support (#26)
Browse files Browse the repository at this point in the history
  • Loading branch information
sspat authored Jan 17, 2022
1 parent 2b6ac64 commit aae18c3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ If you choose this path, you can install this package in the following steps:
```
Then depending on the version of doctrine/orm you want to use:

- run `composer require sspat/doctrine-nullable-embeddables:v2.10.0 doctrine/orm:2.10.0`
- run `composer require sspat/doctrine-nullable-embeddables:v2.9.6 doctrine/orm:2.9.6`
- run `composer require sspat/doctrine-nullable-embeddables:v2.9.5 doctrine/orm:2.9.5`
- run `composer require sspat/doctrine-nullable-embeddables:v2.9.4 doctrine/orm:2.9.4`
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"require": {
"php": "^7.4|^8.0",
"cweagans/composer-patches": "^1.6|^1.7",
"doctrine/orm": "2.9.6"
"doctrine/orm": "2.10.0"
},
"require-dev": {
"phpunit/phpunit": "^9.5"
Expand All @@ -31,7 +31,7 @@
"extra": {
"patches": {
"doctrine/orm": {
"Allow nullable embeddables": "https://raw.githubusercontent.com/sspat/doctrine-nullable-embeddables/v2.9.6/patch/nullable_embeddables.patch"
"Allow nullable embeddables": "https://raw.githubusercontent.com/sspat/doctrine-nullable-embeddables/v2.10.0/patch/nullable_embeddables.patch"
}
}
},
Expand Down
9 changes: 5 additions & 4 deletions patch/nullable_embeddables.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/lib/Doctrine/ORM/Mapping/ReflectionEmbeddedProperty.php b/lib/Doctrine/ORM/Mapping/ReflectionEmbeddedProperty.php
index 4a89c90..60f67be 100644
index 9e6a4a2..f39b81b 100644
--- a/lib/Doctrine/ORM/Mapping/ReflectionEmbeddedProperty.php
+++ b/lib/Doctrine/ORM/Mapping/ReflectionEmbeddedProperty.php
@@ -67,13 +67,16 @@ class ReflectionEmbeddedProperty extends ReflectionProperty
@@ -51,13 +51,16 @@ class ReflectionEmbeddedProperty extends ReflectionProperty
#[ReturnTypeWillChange]
public function getValue($object = null)
{
Expand All @@ -21,7 +21,7 @@ index 4a89c90..60f67be 100644
}

/**
@@ -84,7 +87,20 @@ class ReflectionEmbeddedProperty extends ReflectionProperty
@@ -68,7 +71,21 @@ class ReflectionEmbeddedProperty extends ReflectionProperty
#[ReturnTypeWillChange]
public function setValue($object, $value = null)
{
Expand All @@ -37,7 +37,8 @@ index 4a89c90..60f67be 100644
+ return;
+ }
+
+ $embeddedObject = ! $this->parentProperty->getDeclaringClass()->isInstance($object) || $this->parentProperty->isInitialized($object) ?
+ $embeddedObject = ! $this->parentProperty->getDeclaringClass()->isInstance($object) ||
+ $this->parentProperty->isInitialized($object) ?
+ $this->parentProperty->getValue($object) :
+ null;

Expand Down

0 comments on commit aae18c3

Please sign in to comment.