Fix recursive search in Client.get_items #799
Open
+17,982
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
requested changes
May 15, 2025
|
|
||
| Return: | ||
| Iterator[Item]: Iterator of items whose parent is this | ||
| catalog. | ||
| """ | ||
| if self.conforms_to(ConformanceClasses.ITEM_SEARCH): | ||
| search = self.search(ids=ids) | ||
| if recursive: |
There was a problem hiding this comment.
This is maybe overly cautious but I would prefer this to be:
Suggested change
| if recursive: | |
| if recursive is not False: |
Just to ensure that in the (unlikely) case where someone is passing recursive=None they get recursion to match the behavior before this PR.
Comment on lines
+465
to
+467
| except APIError: | ||
| child_catalogs = [catalog for catalog, _, _ in self.walk()] | ||
| search = self.search(ids=ids, collections=[self, *child_catalogs]) |
There was a problem hiding this comment.
This seems like it would be pretty easy to do accidentally. I think I'd prefer to just let the error raise and make it a little harder to get every single item in planetary computer for instance.
| for item in super().get_items( | ||
| *ids, recursive=recursive is None or recursive | ||
| ): | ||
| for item in super().get_items(*ids, recursive=recursive): |
There was a problem hiding this comment.
I think we still want to account for the possibility of recursive being None here.
Suggested change
| for item in super().get_items(*ids, recursive=recursive): | |
| for item in super().get_items( | |
| *ids, recursive=recursive is None or recursive | |
| ): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Client.get_itemshas surprising recursive behaviour when using the/searchendpoint #798Description:
FalsePR Checklist: