refactor read/write connection pool #240
Open
+323
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
May 13, 2025
bitner
reviewed
May 14, 2025
bitner
approved these changes
May 14, 2025
vincentsarago
commented
May 14, 2025
|
|
||
| if add_write_connection_pool: | ||
| if not write_postgres_settings: | ||
| write_postgres_settings = postgres_settings |
There was a problem hiding this comment.
by default we will re-use postgres_settings (either defined by the user or from env)
hrodmn
reviewed
May 15, 2025
There was a problem hiding this comment.
The changes look good to me but I just want to note that users will not be able to configure a custom PGHOST for database writes using environment variables anymore. Users will need to have a custom application runtime in order to do that now.
I have a few little suggestions for more friendly backwards compatibility.
Co-authored-by: Henry Rodman <[email protected]>
hrodmn
reviewed
May 15, 2025
Comment on lines
56
to
62
| postgres_user: postgres username. | ||
| postgres_pass: postgres password. | ||
| postgres_host_reader: hostname for the reader connection. | ||
| postgres_host_writer: hostname for the writer connection. | ||
| postgres_host: hostname for the connection. | ||
| postgres_port: database port. | ||
| postgres_dbname: database name. | ||
| use_api_hydrate: perform hydration of stac items within stac-fastapi. | ||
| invalid_id_chars: list of characters that are not allowed in item or collection ids. |
There was a problem hiding this comment.
I think these should be pg* instead of postgres_*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #238