Enable linting #732
Draft
Enable linting #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The super-linter.env currently has the following additions that are to be addressed in the future: VALIDATE_GITHUB_ACTIONS=false VALIDATE_SHELL_SHFMT=false VALIDATE_YAML=false Most of the linting for the above has been addressed with just a single issue remaining that blocks the linter from being enabled.
maxstack
force-pushed
the
ci/enable-linting
branch
2 times, most recently
from
39c71e5 to
e6e6e9c
Compare
maxstack
force-pushed
the
ci/enable-linting
branch
from
e6e6e9c to
7ed8866
Compare
maxstack
force-pushed
the
ci/enable-linting
branch
from
65e8371 to
7f8e61a
Compare
…oup where the name parameter was added.
Reverting to ansible.builtin.group: <args>
becasue args aren't an expected label:
groupadd: '{'name': 'grafana', 'gid': 979}' is not a valid group name
maxstack
force-pushed
the
ci/enable-linting
branch
9 times, most recently
from
ca9e48a to
5206d97
Compare
maxstack
force-pushed
the
ci/enable-linting
branch
5 times, most recently
from
4818da6 to
e6a0847
Compare
…and maintains functionality
maxstack
force-pushed
the
ci/enable-linting
branch
from
e6a0847 to
32326a9
Compare
sjpb
reviewed
Aug 29, 2025
| name: Test extra build | ||
| on: | ||
| workflow_dispatch: | ||
| push: |
There was a problem hiding this comment.
How is this OK that we've lost the push and pull_request triggers?
There was a problem hiding this comment.
Can we get something in docs/ on how to run this locally too please, assuming you've been doing that/its reasonably possible?
|
|
||
| exclude_paths: | ||
| - actionlint.yml | ||
| - .ansible/ |
There was a problem hiding this comment.
what's this going to be for?
| - actionlint.yml | ||
| - .ansible/ | ||
| - .github/ | ||
| # The following are files with syntax errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ansible-lintandsuper-linterto the Github PR workflow