-
Notifications
You must be signed in to change notification settings - Fork 696
wip: state machine updates for tx replay #6020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
wip: state machine updates for tx replay #6020
Conversation
…o feat/fork-detection-state-machine
Current state of this PR:
|
"prior_state_machine.burn_block" => %prior_state_machine.burn_block, | ||
); | ||
// Determine the tenures that were forked | ||
let mut sortition_info = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a WIP so sorry about being nit picky already on eit, but I would make this into a sep function such as handle_bitcoin_fork
or extract_replay_transactions
as bitcoin_block_arrival
is getting a bit long/hard to follow.
info!("No stacks parent ch found for sortition info"; | ||
"sortition_info" => ?sortition_info, | ||
); | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no sortition occurred, this could be none, right? Does that mean we should just break from this loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, looking at the API now, it does seem like this will be None
if no sortition occurred, and we don't actually want to break from the loop in that case. I'll have to re-think this a bit.
This PR implements:
This builds on top of #5994