-
Notifications
You must be signed in to change notification settings - Fork 60
Updated navigation and section changed english to bangla #189
base: main
Are you sure you want to change the base?
Conversation
Translated passing data through props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kmdshojib
Thanks a lot for the initiative.
I have checked the PR and file changes to provide some feedbacks.
I have mentioned, the changes required for your changes to be merged.
Looking forward to your changes and more contributions from you.
.vscode/extensions.json
Outdated
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This vscode specific file can not be included into the repository.
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line numbers still don't match after the corrections. There are a few extra new lines left in the Bengali translation. The lines must match with the english version so that the translations can be updated accordingly once the english documentation gets updated.
Can you specify which lines are not matching? |
I have changed the navigation
Overview
What is react
Inspecting the Starter Code