Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Updated navigation and section changed english to bangla #189

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

kmdshojib
Copy link

I have changed the navigation

Overview
What is react
Inspecting the Starter Code

@kmdshojib kmdshojib changed the title Updated navigation changed english to bangla Updated navigation and section changed english to bangla Jul 11, 2022
@kmdshojib
Copy link
Author

Translated passing data through props
Translated Making an Interactive Component section

Copy link
Contributor

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kmdshojib
Thanks a lot for the initiative.
I have checked the PR and file changes to provide some feedbacks.

I have mentioned, the changes required for your changes to be merged.

Looking forward to your changes and more contributions from you.

@@ -0,0 +1,5 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vscode specific file can not be included into the repository.

content/tutorial/nav.yml Outdated Show resolved Hide resolved
content/tutorial/nav.yml Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
kmdshojib and others added 17 commits July 26, 2022 09:31
Co-authored-by: Shakib Hossain <[email protected]>
Co-authored-by: Shakib Hossain <[email protected]>
Copy link
Contributor

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line numbers still don't match after the corrections. There are a few extra new lines left in the Bengali translation. The lines must match with the english version so that the translations can be updated accordingly once the english documentation gets updated.

@kmdshojib
Copy link
Author

Can you specify which lines are not matching?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants