This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Sync with reactjs.org @ 71cc6be6 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Add React Finland 2021 * Update content/community/conferences.md * Update conferences.md Co-authored-by: Alexey Pyltsyn <[email protected]>
Add Omaha React/Node/NextJs Meetup Group link.
Full Stack Open course is part of the computer science studies in the University of Helsinki, and also offered as a free massive open online course (MOOC). The main focus is on building single page applications with React that use REST APIs built with Node.js. It is available in English, Spanish, Chinese and Finnish.
* Update conferences.md * Update conferences.md Co-authored-by: Alexey Pyltsyn <[email protected]>
* Fix URL's anchor to "Callback Refs" page Replace "#the-ref-callback-attribute" with "#callback-refs" * Update content/docs/reference-react-dom.md Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Alexey Pyltsyn <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]>
Co-authored-by: Alexey Pyltsyn <[email protected]>
I have found outdated link. I think we should update this link to direct link without additional redirect.
https://reactlive.nl/ has been cancelled completely so removing from the conference page.
Co-authored-by: Sebastian Silbermann <[email protected]>
I propose that "storing information from previous renders" sounds less like a _cool thing_ and also more clearly describes the rare cases this pattern is for.
Updated the imported `react-router-dom` Component `BrowserRouter` to read as `BrowserRouter as Router` since the code example has it as `Router` instead of `BrowserRouter` Alternatively, can change the `<Router></Router>` component to be `<BrowserRouter>...</BrowserRouter>`
* sandpack error icon overlapping issue fix * modified errorline css
* Generate Ids when there are no headings * Tweak code Co-authored-by: Dan Abramov <[email protected]>
* [Beta] useState Troubleshooting * Tweaks * tweak
* docs: phrasing a sentence * Update extracting-state-logic-into-a-reducer.md Co-authored-by: dan <[email protected]>
Co-authored-by: dan <[email protected]>
* small fixes to stopwatch codesandbox noticed that the explanation for the first stopwatch codesandbox mentions "update the time every 10 milliseconds" so updated the codesandbox to reflect that also there's a small nuanced bug in the second stopwatch codesandbox where each call to `handleStart()` sets a new interval without checking if there's already one ongoing. Ie: If the user accidentally double clicks the start button, they set two intervals for updating `now` every 10ms and then intervalRef only retains the second interval ID. Thus, it's impossible to actually stop the timer because `handleStop()` will only clear the latest set interval while the original one will keep executing. * Update referencing-values-with-refs.md * Update referencing-values-with-refs.md * Update referencing-values-with-refs.md Co-authored-by: dan <[email protected]>
Hopefully people know you can do things other than render it but most of our examples have it in the JSX directly, so it might help to be explicit.
Taking examples of [MDN](https://developer.mozilla.org/en-US/docs/Web/API/queueMicrotask) or [Swift](https://developer.apple.com/documentation/swift/1541053-print), the name used in signatures (assuming this name will be used by type defs like in TS and [Flow](https://github.com/facebook/flow/blob/main/lib/react.js#L343)) is probably more often called as "Parameters". I don't have a strong opinion on this since the distinction are minor and often confusing, but it looks a bit unfamiliar to me as titles. I think use "arguments" interchangeably in other part of writing is fine otherwise it's too much of a mental burden.
This reverts commit cd1717b.
* [Beta] Fix layout shift from previews * Arbitrary values * Fix borked style * Remove custom styles and start again * Recreate existing layout * Try to make it work * Fix TS Co-authored-by: Dan Lebowitz <[email protected]>
* [Beta] Change render() API page format * Tweaks
* [Beta] Mention batching in useState * Fix up link * Tidy it up
`/reference/setState` -> `/apis/usestate#setstate`
* [beta] Reword "action = what happened" advice for useReducer One learner misinterpreted the original text here as meaning instead that it's important that actions are written in past tense – this updated wording is clearer about what this is meant to convey (I think). * typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at 71cc6be
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.