-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #87
Minor fixes #87
Conversation
Hi, the lifetimes fixes are fine but I am not ready to review #68 as it might break some tests upstream. |
A missing lifetime in the GetHeader trait was inferred by lifetime elision rules to be shorter than necessary, leading to awkward lifetime constraints being propagated throughout many functions that didnt need them.
I'm aware and think it is good not to merge #68 as-is without in-depth testing. All other commits have been structured so their correctness is as obvious as can be from looking at the diff. I've pushed some formatting tweaks to make the diffs even smaller. |
Some of the commits in PR #68 I think are valuable on their own, I've extracted them into this PR, and added intermediate steps to justify the changes. As I was doing this, I saw some other issues, and added fixes for that as well.