feat(teleserver, build) MAX_CHANNELS set from CLI #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without needing to modify sources under git modifications (`Makefile` file).
|
Apologies for having to delete my fork, have now restored my PR branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If my understand is correct, the build-time default value
MAX_CHANNELS=16limits the maximum simultaneous devices that can transmit data to theteleserver.Hence it's a quite frequent need to increase this value for those of use with multiple devices.
Currently it is impossible to change
MAX_CHANNELSwithout modifying theMakefilefile (under git-control),which is is error-prone when transferring server installations.
With the changes here, it is possible to use this
makecommand to increase the channels on build-time: