Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added caching for basic corelib defs in the same structure. #7113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 19, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi requested a review from TomerStarkware January 19, 2025 12:37
@orizi orizi force-pushed the spr/main/341919b2 branch from 03fa830 to 4e2ac87 Compare January 19, 2025 12:40
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 25 files at r1, all commit messages.
Reviewable status: 24 of 25 files reviewed, all discussions resolved

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 24 of 25 files reviewed, all discussions resolved

@orizi orizi force-pushed the spr/main/341919b2 branch from 4e2ac87 to 37d1f8d Compare January 20, 2025 04:38
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants