refactor(native_blockifier, starknet_consensus_orchestrator): share execution objects #3877
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Yael-Starkware
force-pushed
the
yael/share_central_execution_info
branch
2 times, most recently
from
1e2edc0 to
e518a0e
Compare
There was a problem hiding this comment.
Why not just import the execution info from the native blockifier crate?
Reviewable status: 0 of 12 files reviewed, all discussions resolved
There was a problem hiding this comment.
because the consensus orchestrator doesn't need to include the native blockifier, it doesn't have anything to do with it.
besides, that was what we agreed with Lior, that the execution object will be moved to a different crate that will be shared by other crates. This is the first object, and more to come.
Reviewable status: 0 of 12 files reviewed, all discussions resolved
Yael-Starkware
force-pushed
the
yael/share_central_execution_info
branch
from
e518a0e to
678ac37
Compare
There was a problem hiding this comment.
What else?
Reviewable status: 0 of 12 files reviewed, all discussions resolved
Yael-Starkware
force-pushed
the
yael/share_central_execution_info
branch
from
678ac37 to
8e8968c
Compare
There was a problem hiding this comment.
bouncer_weights, transaction_execution_info, commitment_state_diff
Reviewable status: 0 of 14 files reviewed, all discussions resolved
There was a problem hiding this comment.
these are the objects that are passed from the batcher to the consensus_orchestrator.
Reviewable status: 0 of 14 files reviewed, all discussions resolved
Yael-Starkware
force-pushed
the
yael/share_central_execution_info
branch
from
8e8968c to
00aeb44
Compare
No description provided.