fix(papyrus_p2p_sync): tx and state_diff tests wait for headers sync #3891
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
noamsp-starkware
force-pushed
the
noam.s/fix_papyrus_p2p_sync_Tx_state_diff_tests_wait_for_headers_sync
branch
from
f1d2327 to
ac87ca5
Compare
noamsp-starkware
force-pushed
the
noam.s/fix_papyrus_p2p_sync_Tx_state_diff_tests_wait_for_headers_sync
branch
from
ac87ca5 to
585542f
Compare
noamsp-starkware
changed the title
noamsp-starkware
force-pushed
the
noam.s/fix_papyrus_p2p_sync_Tx_state_diff_tests_wait_for_headers_sync
branch
from
585542f to
6dbe3ca
Compare
noamsp-starkware
changed the title
ShahakShama
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)
crates/papyrus_p2p_sync/src/client/transaction_test.rs line 47 at r1 (raw file):
]; // Sleep so transaction sync will wait for new data
Same
crates/papyrus_p2p_sync/src/client/state_diff_test.rs line 106 at r1 (raw file):
]; // Sleep so state diff sync will wait for new data
will reach the sleep waiting for new data
noamsp-starkware
force-pushed
the
noam.s/test_papyrus_p2p_sync_fix_class_from_syncing_before_state_diff_finishes
branch
from
e6d9b3f to
28c4a58
Compare
noamsp-starkware
force-pushed
the
noam.s/fix_papyrus_p2p_sync_Tx_state_diff_tests_wait_for_headers_sync
branch
from
6dbe3ca to
ab553d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.