feat(starknet_integration_tests): add db path argument to node_setup …

[nadin-Starkware]

…for configurable DB storage

commit-id:2e49fc49

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/starknet_integration_tests/src/node_setup.rs line 48 at r1 (raw file):

        }
    }
}

Arg parsing of a single given binary should probably in that binary module.

Code quote:

// TODO(Nadin): Improve the argument parsing.
pub fn get_base_db_path(args: Vec<String>) -> PathBuf {
    let arg_name = "--base_db_path_dir";
    match args.as_slice() {
        [] => PathBuf::from("./data"),
        [arg, path] if arg == arg_name => PathBuf::from(path),
        _ => {
            eprintln!("Error: Bad argument. The only allowed argument is '{}'.", arg_name);
            std::process::exit(1);
        }
    }
}

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

---

crates/starknet_integration_tests/src/node_setup.rs line 48 at r1 (raw file):

        }
    }
}

PTAL at how the node binary parses args:

https://github.com/starkware-libs/sequencer/blob/main/crates/papyrus_config/src/command.rs#L10-L16

Code quote:

pub fn get_base_db_path(args: Vec<String>) -> PathBuf {
    let arg_name = "--base_db_path_dir";
    match args.as_slice() {
        [] => PathBuf::from("./data"),
        [arg, path] if arg == arg_name => PathBuf::from(path),
        _ => {
            eprintln!("Error: Bad argument. The only allowed argument is '{}'.", arg_name);
            std::process::exit(1);
        }
    }
}

[nadin-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_integration_tests/src/node_setup.rs line 48 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Arg parsing of a single given binary should probably in that binary module.

Done.

[Itay-Tsabary-Starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

[nadin-Starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-05T14:13:16Z
• Started at 2025-02-05T14:47:31Z

[nadin-Starkware]

Reviewed 8 of 8 files at r4.
Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @nadin-Starkware)

[nadin-Starkware]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)