feat(blockifier_test_utils): move RunnableCairo1 from blockifier::test_utils and update dependencies #3969
Conversation
|
This change is |
rotem-starkware
requested review from
AvivYossef-starkware and
dorimedini-starkware
There was a problem hiding this comment.
Reviewed 44 of 44 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @rotem-starkware)
crates/blockifier_test_utils/Cargo.toml line 10 at r1 (raw file):
[features] cairo_native = []
the blockifier Cargo.toml needs to be updated: if it's cairo_native feature is active, then the blockifier_test_utils cairo_native feature also needs to beactive
Code quote:
[features]
cairo_native = []
rotem-starkware
changed the base branch from
rotem/move_blockifier_test_utils_cairo_compile
to
graphite-base/3969
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
from
653fa02 to
2db9ddb
Compare
rotem-starkware
force-pushed
the
graphite-base/3969
branch
from
72790f9 to
7556abb
Compare
|
Previously, dorimedini-starkware wrote…
Done. |
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
4 times, most recently
from
3103892 to
2dc9eff
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
from
2dc9eff to
9d7c4fa
Compare
rotem-starkware
force-pushed
the
graphite-base/3969
branch
from
7556abb to
8fe844b
Compare
There was a problem hiding this comment.
Reviewed 22 of 22 files at r3, all commit messages.
Reviewable status:
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
from
9d7c4fa to
902ddee
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status:
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
from
902ddee to
6210c9f
Compare
rotem-starkware
force-pushed
the
graphite-base/3969
branch
from
8fe844b to
952a81a
Compare
There was a problem hiding this comment.
Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status:
crates/starknet_gateway/Cargo.toml line 17 at r5 (raw file):
async-trait.workspace = true axum.workspace = true blockifier = { workspace = true, optional = true }
the gateway doesn't need the blockifier at all, unless the testing feature is active?
seems strange to me...
can you try running cargo build -p starknet_gateway and see that it compiles?
you may need to drop the optional = true here
Code quote:
blockifier = { workspace = true, optional = true }
…t_utils and update dependencies
rotem-starkware
force-pushed
the
rotem/move_blockifier_test_utils_runnablecairo1
branch
from
6210c9f to
97fb391
Compare
|
Previously, dorimedini-starkware wrote…
your'e right, I fixed it. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:
No description provided.