feat(blockifier): integrate Casm read from class manager client #3983
Conversation
|
This change is |
elintul
force-pushed
the
elin/class-manager/papyrus-state/read-from-class-manager-client
branch
5 times, most recently
from
261626c to
17af2c7
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @elintul, and @meship-starkware)
crates/papyrus_state_reader/src/papyrus_state.rs line 54 at r2 (raw file):
contract_class_manager, // TODO(Elin): integrate class manager client. class_reader: None,
Out of curiosity- where do you set this to Some?
Code quote:
class_reader: None,
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @elintul)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
crates/papyrus_state_reader/src/papyrus_state.rs line 54 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Out of curiosity- where do you set this to
Some?
Good Q (I guess you looked it up); nowhere yet. Shahak's team is still helping me integrating the class manager.
It will be set to Some(class_manager_client) when the new Batcher's state reader is initialized. :)
elintul
force-pushed
the
elin/class-manager/papyrus-state/read-from-class-manager-client
branch
from
17af2c7 to
ad7dd2a
Compare
elintul
requested review from
avivg-starkware
and removed request for
AvivYossef-starkware
Chose this simpler option to implement, instead of making Papyrus state generic by `CR: CasmReader` trait, since it would require cloning `mdbx` resources, which is flaky working with PyO3. After `native_blockifier` is deprecated, the client should become non-`Option` and Papyrus state (in the new Batcher) should always be initialized with a concrete instance.
elintul
force-pushed
the
elin/class-manager/papyrus-state/read-from-class-manager-client
branch
from
ad7dd2a to
4d6c655
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
Chose this simpler option to implement, instead of making Papyrus state generic by
CR: CasmReadertrait, since it would require cloningmdbxresources, which is flaky working with PyO3.After
native_blockifieris deprecated, the client should become non-Optionand Papyrus state (in the new Batcher) should always be initialized with a concrete instance.