Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(starknet_mempool_p2p): use random tx in runner tests #4035

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix(starknet_mempool_p2p): use random tx in runner tests #4035

merged 1 commit into from
Feb 9, 2025

Conversation

AlonLStarkWare
Copy link
Contributor

  • fix(papyrus_test_utils): generate random values for resource bounds test instance
  • fix(starknet_mempool_p2p): use random tx in runner tests

@reviewable-StarkWare
Copy link

This change is Reviewable

ShahakShama
ShahakShama approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

@AlonLStarkWare AlonLStarkWare force-pushed the alonl/test_random_tx_in_mempool_p2p_runner branch from a6c31cb to d4ec5db Compare February 9, 2025 12:51
ShahakShama
ShahakShama approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

@AlonLStarkWare AlonLStarkWare added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit 1d1f2a0 Feb 9, 2025
10 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ShahakShama ShahakShama ShahakShama approved these changes

@eitanm-starkware eitanm-starkware Awaiting requested review from eitanm-starkware

@noamsp-starkware noamsp-starkware Awaiting requested review from noamsp-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlonLStarkWare @reviewable-StarkWare @ShahakShama