Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(papyrus_test_utils): generate random values for resource bounds test instance #4036

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

AlonLStarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware and @noamsp-starkware)


crates/papyrus_test_utils/src/lib.rs line 1190 at r1 (raw file):

}

impl GetTestInstance for ResourceBounds {

Add comment why you do this. Say that the default value is invalid in some circumstances


crates/papyrus_test_utils/src/lib.rs line 1200 at r1 (raw file):

}

impl GetTestInstance for AllResourceBounds {

You can use the macro one for AllResourceBounds once you change the one for ResourceBounds. It will do the same as what you wrote here

@AlonLStarkWare AlonLStarkWare force-pushed the alonl/fix_resource_bounds_test_instance branch from 3188762 to c44e6a1 Compare February 9, 2025 11:56
Copy link
Contributor Author

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware, @noamsp-starkware, and @ShahakShama)


crates/papyrus_test_utils/src/lib.rs line 1190 at r1 (raw file):

Previously, ShahakShama wrote…

Add comment why you do this. Say that the default value is invalid in some circumstances

Done


crates/papyrus_test_utils/src/lib.rs line 1200 at r1 (raw file):

Previously, ShahakShama wrote…

You can use the macro one for AllResourceBounds once you change the one for ResourceBounds. It will do the same as what you wrote here

Done

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

@AlonLStarkWare AlonLStarkWare added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit 250f9df Feb 9, 2025
19 of 28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants