refactor(papyrus_sync): update metrics tracking

[AlonLStarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-10T15:53:00Z
• Started at 2025-02-11T09:58:28Z
• Started at 2025-02-11T10:01:07Z
• Started at 2025-02-11T12:25:23Z
• Started at 2025-02-12T09:24:34Z
• Started at 2025-02-12T14:07:17Z
• Started at 2025-02-12T15:17:04Z

[ShahakShama]

Reviewed 12 of 13 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware and @noamsp-starkware)

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 92 at r2 (raw file):

    },
    MetricScope::PapyrusSync => {
        { PAPYRUS_HEADER_MARKER, "papyrus_header_marker", "The first block number for which the node does not have a header" },

PAPYRUS/papyrus -> SYNC/apollo_sync
Also, while you're at it, change STATE_SYNC above to SYNC

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 92 at r2 (raw file):

    },
    MetricScope::PapyrusSync => {
        { PAPYRUS_HEADER_MARKER, "papyrus_header_marker", "The first block number for which the node does not have a header" },

In every description, change "the node" into sync

[AlonLStarkWare]

Reviewable status: 3 of 13 files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware, @noamsp-starkware, and @ShahakShama)

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 92 at r2 (raw file):

Previously, ShahakShama wrote…

PAPYRUS/papyrus -> SYNC/apollo_sync
Also, while you're at it, change STATE_SYNC above to SYNC

Done.

---

crates/starknet_sequencer_metrics/src/metric_definitions.rs line 92 at r2 (raw file):

Previously, ShahakShama wrote…

In every description, change "the node" into sync

Done.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.898 ms 34.970 ms 35.043 ms]
change: [-4.0844% -2.6460% -1.3804%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

[ShahakShama]

Reviewed 1 of 7 files at r3, 1 of 4 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)