test(starknet_integration_tests): add revert flow integration test

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• WIP_INTEGRATION_REVER_FLOW_TEST #4114
• test(starknet_integration_tests): add revert flow integration test #4076 👈 (View in Graphite)
• feat(starknet_integration_tests): add snapshot tx generator fn #4075
• feat(starknet_integration_tests): add update revert config #4074
• feat(starknet_state_sync): add revert_up_to_and_including option #3989
• feat(apollo_reverts): add revert blocks functionality #3988
• feat(papyrus_storage): add revert class manager marker #3987
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 16 at r1 (raw file):

#[tokio::main]
async fn main() {
    configure_tracing().await;

Call the setup instead

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 53 at r1 (raw file):

    // Run the first block scenario to bootstrap the accounts.
    integration_test_manager.send_bootstrap_txs_and_verify().await;
    integration_test_manager.send_invoke_txs_and_verify(N_TXS, BLOCK_TO_REVERT_TO).await;

You can erase this send and have the blocks that we revert to just contain the bootstrap txs

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 57 at r1 (raw file):

    let tx_generator_snapshot = integration_test_manager.snapshot_tx_generator();
    integration_test_manager.send_invoke_txs_and_verify(N_TXS, BLOCK_TO_REVERT_FROM).await;
    integration_test_manager.shutdown_nodes(node_indices.clone());

Add log before this line

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 61 at r1 (raw file):

    integration_test_manager.run_nodes(node_indices.clone()).await;
    // allow the nodes to revert the blocks.
    sleep(Duration::from_secs(5));

Move this Duration to a constant

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 61 at r1 (raw file):

    integration_test_manager.run_nodes(node_indices.clone()).await;
    // allow the nodes to revert the blocks.
    sleep(Duration::from_secs(5));

Add logs before and after this sleep. Something like: "Waiting X seconds for revert to finish" and "Finished waiting for revert to finish. Checking it succeeded and turning the config off

---

crates/starknet_integration_tests/src/bin/sequencer_node_end_to_end_revert_flow_integration_test.rs line 61 at r1 (raw file):

    integration_test_manager.run_nodes(node_indices.clone()).await;
    // allow the nodes to revert the blocks.
    sleep(Duration::from_secs(5));

Poll the marker with small sleeps between each poll instead of sleeping and checking it after 5 seconds (The comments above are still relevant, you should log what you're doing in the test and put the polling durations in constants)

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama)

---

-- commits line 2 at r2:
There should be a different value for each integration test, so please:

1. In a preceding pr, please move this value to be defined in the binary, and not interally in this function. Pass this value as an arg up to the current definition location.
2. For this pr, create a new enum variant (and also rename the current one), and use it in this binary

sequencer/crates/starknet_integration_tests/src/sequencer_manager.rs

Line 338 in e99555e

let test_unique_id = TestIdentifier::EndToEndIntegrationTest;

Code quote:

- b6e2103: test(starknet_integration_tests): add revert flow integration test